Skip to content

chore: depend on hotdata-framework (renamed from hotdata-runtime)#26

Merged
eddietejeda merged 2 commits into
mainfrom
chore/rename-hotdata-framework
Jun 27, 2026
Merged

chore: depend on hotdata-framework (renamed from hotdata-runtime)#26
eddietejeda merged 2 commits into
mainfrom
chore/rename-hotdata-framework

Conversation

@eddietejeda

Copy link
Copy Markdown
Contributor

Renames the dependency from hotdata-runtime to hotdata-framework (same package, renamed) and updates imports to hotdata_framework.

Merge order: hotdata-framework must be published to PyPI first; then uv.lock here needs regenerating (uv lock) before CI uv sync --locked will pass.

claude[bot]
claude Bot previously approved these changes Jun 27, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, consistent rename of hotdata-runtimehotdata-framework across dependabot, pyproject description, publish script, and guardrail tests. No stray references remain in either direction, and the guardrails correctly continue to enforce independence from the renamed package.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, consistent rename of hotdata-runtimehotdata-framework across all files. No leftover references remain, and the guardrail tests still pass.

One note (non-blocking, about the PR description rather than the code): the title/body say this makes hotdata-ibis depend on hotdata-framework and update imports to hotdata_framework. The diff does the opposite — it keeps the architecture guardrails that forbid depending on / importing that package (the package depends on the hotdata SDK only). As a result the merge-order note (publish hotdata-framework to PyPI, then regenerate uv.lock) doesn't apply, since hotdata-framework is not a dependency — uv.lock only needs to track the version bump, which it already does (0.1.4 → 0.1.5). Worth correcting the description so the intent is clear; the code itself is correct.

@eddietejeda eddietejeda merged commit a658c17 into main Jun 27, 2026
8 checks passed
@eddietejeda eddietejeda deleted the chore/rename-hotdata-framework branch June 27, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant